Skip to content

Conversation

@5t3ph
Copy link
Contributor

@5t3ph 5t3ph commented Jul 17, 2025

Description

Aligns with PR by @castastrophe on SWC

Replace deprecated word-break: break-word with overflow-wrap: break-word to align with modern CSS standards and improve cross-browser compatibility. This property was deprecated in Chrome 44 (July 2015) in favor of the standardized overflow-wrap property.

How and where has this been tested?

Please tag yourself on the tests you've marked complete to confirm the tests have been run by someone other than the author.

Validation steps

  • Review tooltip and modify the content property to add a long enough text string that needs to break, and ensure it doesn't cause layout overflow
  • Review sidenav and modify the content of a link to add a long enough text string that needs to break, and ensure it doesn't cause layout overflow

Regression testing

Validate:

  1. The documentation pages for at least two other components are still loading, including:
  • The pages render correctly, are accessible, and are responsive.

To-do list

  • I have read the contribution guidelines.
  • I have updated relevant storybook stories and templates.
  • I have tested these changes in Windows High Contrast mode.
  • If my change impacts other components, I have tested to make sure they don't break.
  • If my change impacts documentation, I have updated the documentation accordingly.
  • ✨ This pull request is ready to merge. ✨

@5t3ph 5t3ph added bug Results from a bug in the CSS implementation size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day. S2 Spectrum 2 labels Jul 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2025

📚 Branch preview

PR #4044 has been deployed to Azure Blob Storage: https://spectrumcss.z13.web.core.windows.net/pr-4044/index.html.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 17, 2025

File metrics

Summary

Total size: 1.43 MB*
No change in file sizes

Package Size Minified Gzipped
sidenav 14.44 KB 13.79 KB 2.23 KB
tooltip 31.97 KB 30.72 KB 3.11 KB

File change details

sidenav

Filename Head Minified Gzipped Compared to base
index.css 14.44 KB 13.79 KB 2.23 KB 🔴 ⬆ 0.02 KB
metadata.json 8.59 KB - - -

tooltip

Filename Head Minified Gzipped Compared to base
index.css 31.97 KB 30.72 KB 3.11 KB 🔴 ⬆ 0.02 KB
metadata.json 20.57 KB - - -
* Size is the sum of all main files for packages in the library.
* An ASCII character in UTF-8 is 8 bits or 1 byte.

@changeset-bot
Copy link

changeset-bot bot commented Jul 17, 2025

🦋 Changeset detected

Latest commit: 19278b5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@spectrum-css/sidenav Patch
@spectrum-css/tooltip Patch
@spectrum-css/bundle Patch
@spectrum-css/preview Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@cdransf cdransf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! ✨

@5t3ph 5t3ph merged commit b1166bd into spectrum-two Jul 18, 2025
13 checks passed
@5t3ph 5t3ph deleted the seckles/css-1223-word-break branch July 18, 2025 14:48
@github-actions github-actions bot mentioned this pull request Jul 26, 2025
@castastrophe castastrophe mentioned this pull request Aug 6, 2025
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Results from a bug in the CSS implementation S2 Spectrum 2 size-1 XS ~1-6hrs; nearly trivial, a few hours, could do more than one in a single day.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants